-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73922/#review224283
-----------------------------------------------------------




security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql
Lines 121 (patched)
<https://reviews.apache.org/r/73922/#comment313145>

    Can we store it in other_attributes to avoid change database schema?



security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java
Lines 431 (patched)
<https://reviews.apache.org/r/73922/#comment313143>

    Can you move this line to init or consturctor?



security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml
Lines 515 (patched)
<https://reviews.apache.org/r/73922/#comment313144>

    typo here


- Kirby Zhou


On 四月 8, 2022, 2:01 p.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73922/
> -----------------------------------------------------------
> 
> (Updated 四月 8, 2022, 2:01 p.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kirby Zhou, Abhay 
> Kulkarni, Madhan Neethiraj, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, 
> Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3687
>     https://issues.apache.org/jira/browse/RANGER-3687
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Password history should be configured to restrict users from reusing their 
> last 4 or 5 passwords.
> 
> 
> Diffs
> -----
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 
> 26282f770 
>   security-admin/db/mysql/patches/059-update-x-portal-user-table.sql 
> PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 0e61038d5 
>   security-admin/src/main/java/org/apache/ranger/entity/XXPortalUser.java 
> d0451b4d2 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> e2bfc8fff 
> 
> 
> Diff: https://reviews.apache.org/r/73922/diff/4/
> 
> 
> Testing
> -------
> 
> 1. Verified the basic functionality of "/passwordchange" api
> 2. Verified "/secure/users" & "/secure/users/{id}" API’s
> 
> 3. Once the basic review/discussion is done will fix the Test-cases
> 
> 
> Thanks,
> 
> bhavik patel
> 
>

Reply via email to