----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74081/#review224606 -----------------------------------------------------------
There are pmd failures, please fix. [INFO] PMD Failure: org.apache.ranger.rest.TestServiceREST:2214 Rule:UnusedPrivateMethod Priority:3 Avoid unused private methods such as 'mockEnsureAdminAccess_2()'.. [INFO] PMD Failure: org.apache.ranger.rest.TestServiceREST:2220 Rule:UnusedPrivateMethod Priority:3 Avoid unused private methods such as 'mockCreatePolicyUnconditionally_1(RangerPolicy)'.. - Pradeep Agrawal On Aug. 3, 2022, 8:53 p.m., Fateh Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74081/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2022, 8:53 p.m.) > > > Review request for ranger, bhavik patel, Dhaval Shah, Abhay Kulkarni, Madhan > Neethiraj, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan > Periasamy. > > > Bugs: Ranger-3849 > https://issues.apache.org/jira/browse/Ranger-3849 > > > Repository: ranger > > > Description > ------- > > ServiceREST.java has methods which doesn't have test cases. Overall coverage > also needs improvement > > > Diffs > ----- > > security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java > 09d55e89d > > > Diff: https://reviews.apache.org/r/74081/diff/2/ > > > Testing > ------- > > Baseline coverage:: class =75% (3/4) method = 60.2% (68/113) > line = 48.3% (1178/2437) > > Wrote unit test cases for ServiceREST.java. > > New coverage :: class = 75% (3/4) method = 75.2% (85/113) > line = 60% (1462/2437) > > > Thanks, > > Fateh Singh > >
