----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74081/#review224607 -----------------------------------------------------------
security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java Lines 2214 (patched) <https://reviews.apache.org/r/74081/#comment313388> This method is causing PMD error. security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java Lines 2220 (patched) <https://reviews.apache.org/r/74081/#comment313389> This method is causing PMD Error. - Pradeep Agrawal On Aug. 9, 2022, 2:02 a.m., Fateh Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74081/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2022, 2:02 a.m.) > > > Review request for ranger, bhavik patel, Dhaval Shah, Abhay Kulkarni, Madhan > Neethiraj, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan > Periasamy. > > > Bugs: Ranger-3849 > https://issues.apache.org/jira/browse/Ranger-3849 > > > Repository: ranger > > > Description > ------- > > ServiceREST.java has methods which doesn't have test cases. Overall coverage > also needs improvement > > > Diffs > ----- > > security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java > 09d55e89d > > > Diff: https://reviews.apache.org/r/74081/diff/3/ > > > Testing > ------- > > Baseline coverage:: class =75% (3/4) method = 60.2% (68/113) > line = 48.3% (1178/2437) > > Wrote unit test cases for ServiceREST.java. > > New coverage :: class = 75% (3/4) method = 75.2% (85/113) > line = 60% (1462/2437) > > > Thanks, > > Fateh Singh > >
