----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74045/#review224616 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java Lines 309 (patched) <https://reviews.apache.org/r/74045/#comment313401> Please review to see if this variable needs to be marked as volatile to have the synchronization code in getMacrosReplacedWithWildcardMatcher() function work correctly. - Abhay Kulkarni On Aug. 9, 2022, 10:56 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74045/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2022, 10:56 p.m.) > > > Review request for ranger, Abhishek Kumar, Ankita Sinha, Kishor > Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, > Subhrat Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-3816 > https://issues.apache.org/jira/browse/RANGER-3816 > > > Repository: ranger > > > Description > ------- > > - updated RangerPolicyEngine.getResourceACLs() to handle policies with macros > in resource values > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 3ae0add51 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceACLs.java > aa49507b8 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java > c16d2acb0 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java > d1c2f7cde > > agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java > 15f2522db > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRequestExprResolver.java > 4e5d949de > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyACLs.java > b6135b096 > agents-common/src/test/resources/policyengine/test_aclprovider_default.json > 37f4f3c2d > > > Diff: https://reviews.apache.org/r/74045/diff/3/ > > > Testing > ------- > > - updated unit test with tests cases for policies with resources like > "test_[USER]" and "/home/${{USER.dept}}" > - verified that all existing unit test pass successfully > > > Thanks, > > Madhan Neethiraj > >
