-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74115/
-----------------------------------------------------------
(Updated Oct. 11, 2022, 3:39 p.m.)
Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja
Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3902
https://issues.apache.org/jira/browse/RANGER-3902
Repository: ranger
Description
-------
Whenever Role creation fails,we used to log the entire role JSON
LOG.error("createRole(" + role + ") failed", excp);
Whenever a Role update fails,we used to log the entire role JSON
LOG.error("updateRole(" + role + ") failed", excp);
Whenever policy creation fails , we used to log the entire policy JSON
LOG.error("createPolicy(" + policy + ") failed", excp);
Whenever a policy update fails, we used to log the entire policy JSON
LOG.error("updatePolicy(" + policy + ") failed", excp);
Proposal :
During role/policy, creation/update fails
We can log roleId/roleName for roles creation/updation .As well as
policyId/policyName for policy creation/updation.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 04968ecc5
security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java
b1447829b
security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java ddff5cd23
security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java
fd2b6aecf
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
c3a65a115
Diff: https://reviews.apache.org/r/74115/diff/2/
Changes: https://reviews.apache.org/r/74115/diff/1-2/
Testing
-------
Tested this change in the log files
Thanks,
Ramachandran Krishnan
