-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74115/
-----------------------------------------------------------

(Updated Oct. 11, 2022, 4:54 p.m.)


Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, 
Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja 
Polavarapu, and Velmurugan Periasamy.


Summary (updated)
-----------------

Logging improvement for creating/updating policy via Rest API


Bugs: RANGER-3902
    https://issues.apache.org/jira/browse/RANGER-3902


Repository: ranger


Description (updated)
-------

Whenever policy creation fails , we used to log the entire policy JSON
 LOG.error("createPolicy(" + policy + ") failed", excp);
Whenever a policy update fails, we used to log the entire policy JSON
 LOG.error("updatePolicy(" + policy + ") failed", excp);
Proposal :

During policy, creation/update fails

We can log policyId/policyName for policy creation/updation.


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 04968ecc5 
  
security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java
 b1447829b 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
c3a65a115 


Diff: https://reviews.apache.org/r/74115/diff/3/

Changes: https://reviews.apache.org/r/74115/diff/2-3/


Testing
-------

Tested this change in the log files


Thanks,

Ramachandran Krishnan

Reply via email to