-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74179/
-----------------------------------------------------------

Review request for ranger, Dhaval Shah, Kirby Zhou, Abhay Kulkarni, Pradeep 
Agrawal, Ramesh Mani, ru jia, and zhouyifan279.


Bugs: RANGER-2128
    https://issues.apache.org/jira/browse/RANGER-2128


Repository: ranger


Description
-------

Implement SparkSQL plugin


Diffs
-----

  agents-common/scripts/enable-agent.sh 1302ac19c 
  
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
 79e09a1a2 
  agents-common/src/main/resources/service-defs/ranger-servicedef-spark.json 
PRE-CREATION 
  
agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java
 7ee7b75b2 
  distro/pom.xml b187297c4 
  distro/src/main/assembly/admin-web.xml 9b7475492 
  distro/src/main/assembly/plugin-spark.xml PRE-CREATION 
  plugin-spark/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION 
  plugin-spark/conf/ranger-policymgr-ssl.xml PRE-CREATION 
  plugin-spark/conf/ranger-spark-audit-changes.cfg PRE-CREATION 
  plugin-spark/conf/ranger-spark-audit.xml PRE-CREATION 
  plugin-spark/conf/ranger-spark-security-changes.cfg PRE-CREATION 
  plugin-spark/conf/ranger-spark-security.xml PRE-CREATION 
  plugin-spark/pom.xml PRE-CREATION 
  plugin-spark/scripts/install.properties PRE-CREATION 
  
plugin-spark/src/main/java/org/apache/ranger/services/spark/RangerServiceSpark.java
 PRE-CREATION 
  
plugin-spark/src/main/java/org/apache/ranger/services/spark/client/SparkClient.java
 PRE-CREATION 
  
plugin-spark/src/main/java/org/apache/ranger/services/spark/client/SparkResourceMgr.java
 PRE-CREATION 
  
plugin-spark/src/main/java/org/apache/ranger/services/spark/client/json/model/SparkProjectResponse.java
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/ranger/authorization/spark/authorizer/RangerSparkAccessRequest.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/ranger/authorization/spark/authorizer/RangerSparkAuditHandler.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/ranger/authorization/spark/authorizer/RangerSparkAuthorizer.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/ranger/authorization/spark/authorizer/RangerSparkPlugin.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/ranger/authorization/spark/authorizer/RangerSparkResource.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/ranger/authorization/spark/authorizer/RangerSparkSQLExtension.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/ranger/authorization/spark/authorizer/SparkAccessControlException.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/ranger/authorization/spark/authorizer/SparkAccessType.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/ranger/authorization/spark/authorizer/SparkObjectType.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/ranger/authorization/spark/authorizer/SparkOperationType.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/ranger/authorization/spark/authorizer/SparkPrivObjectActionType.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/ranger/authorization/spark/authorizer/SparkPrivilegeObject.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/ranger/authorization/spark/authorizer/SparkPrivilegeObjectType.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/ranger/authorization/spark/authorizer/authorizer.scala
 PRE-CREATION 
  plugin-spark/src/main/scala/org/apache/spark/sql/AuthzUtils.scala 
PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RangerSparkAuthorizerExtension.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RangerSparkMaskingExtension.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RangerSparkOptimizer.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RangerSparkRowFilterExtension.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/RangerSparkMasking.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/RangerSparkRowFilter.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/spark/sql/execution/RangerShowTablesCommand.scala
 PRE-CREATION 
  
plugin-spark/src/main/scala/org/apache/spark/sql/execution/RangerSparkPlanOmitStrategy.scala
 PRE-CREATION 
  plugin-spark/src/main/scala/org/apache/spark/sql/hive/PrivilegesBuilder.scala 
PRE-CREATION 
  plugin-spark/src/test/resources/data/files/kv1.txt PRE-CREATION 
  plugin-spark/src/test/resources/log4j.properties PRE-CREATION 
  plugin-spark/src/test/resources/ranger-spark-security.xml PRE-CREATION 
  plugin-spark/src/test/resources/sparkSql_hive_jenkins.json PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q1.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q10.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q11.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q12.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q13.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q14a.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q14b.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q15.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q16.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q17.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q18.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q19.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q2.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q20.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q21.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q22.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q23a.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q23b.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q24a.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q24b.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q25.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q26.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q27.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q28.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q29.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q3.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q30.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q31.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q32.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q33.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q34.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q35.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q36.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q37.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q38.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q39a.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q39b.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q4.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q40.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q41.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q42.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q43.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q44.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q45.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q46.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q47.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q48.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q49.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q5.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q50.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q51.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q52.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q53.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q54.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q55.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q56.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q57.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q58.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q59.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q6.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q60.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q61.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q62.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q63.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q64.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q65.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q66.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q67.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q68.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q69.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q7.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q70.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q71.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q72.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q73.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q74.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q75.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q76.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q77.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q78.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q79.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q8.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q80.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q81.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q82.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q83.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q84.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q85.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q86.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q87.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q88.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q89.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q9.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q90.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q91.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q92.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q93.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q94.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q95.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q96.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q97.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q98.sql PRE-CREATION 
  plugin-spark/src/test/resources/tpcds/q99.sql PRE-CREATION 
  
plugin-spark/src/test/scala/org/apache/ranger/services/spark/RangerAdminClientImpl.scala
 PRE-CREATION 
  
plugin-spark/src/test/scala/org/apache/ranger/services/spark/SparkRangerAuthorizerTest.scala
 PRE-CREATION 
  plugin-spark/src/test/scala/org/apache/spark/sql/RangerSparkTestUtils.scala 
PRE-CREATION 
  
plugin-spark/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RangerSparkAuthorizerExtensionTest.scala
 PRE-CREATION 
  
plugin-spark/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RangerSparkMaskingExtensionTest.scala
 PRE-CREATION 
  
plugin-spark/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RangerSparkRowFilterExtensionTest.scala
 PRE-CREATION 
  
plugin-spark/src/test/scala/org/apache/spark/sql/execution/RangerSparkPlanOmitStrategyTest.scala
 PRE-CREATION 
  pom.xml 7c794c833 


Diff: https://reviews.apache.org/r/74179/diff/1/


Testing
-------

1. Updated the patch to support spark-3.2.0 version
2. Fixed the build package issue and updated the code structure for plugin 
installation and configs modification.
3. Verified the ACL's functionalities.
4. Tested Column level masking and row level filter functionality.


Thanks,

bhavik patel

Reply via email to