> On Nov. 15, 2022, 6:49 a.m., Subhrat Chaudhary wrote: > > request.getUserRoles() is getting called in > > org.apache.ranger.plugin.service.RangerDefaultRequestProcessor --- > > preProcess. Do we need to update this instance too?
RangerDefaultRequestProcessor.preProcess() shouldn't be changed to use RangerAccessRequestUtil.getUserRoles(), since preProcess() is the method that updates the context with the roles, and the context is used by RangerAccessRequestUtil.getUserRoles(). - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74200/#review224863 ----------------------------------------------------------- On Nov. 13, 2022, 7:39 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74200/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2022, 7:39 a.m.) > > > Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay > Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat > Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-3966 > https://issues.apache.org/jira/browse/RANGER-3966 > > > Repository: ranger > > > Description > ------- > > Replaced use of request.getUserRoles() with > RangerAccessRequestUtil.getUserRoles(request) > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java > 2430c7a74 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > 006aeeecb > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyItemEvaluator.java > 71811767b > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java > c4beabf87 > > > Diff: https://reviews.apache.org/r/74200/diff/1/ > > > Testing > ------- > > verified that all existing tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
