----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74246/#review225003 -----------------------------------------------------------
Ship it! Dhaval - the fixes look good. Thank you for the quick turnaround. Can you please look into following issues as well? 1. While trying to create a policy in Atlas service, 'Type Category' is the default resource shown. Following list is shown for values: classification, enum, enity, relationship, struct, businessmetadata. After changing the resource to any other type, Entity Type/Atlas Service/Relationship Type, the same dropdown list is shown for values. This doesn't look correct. 2. List of values for 'Type Category/Type Name' has entries with value _NOT_CLASSIFIED. This doesn't look correct. - Madhan Neethiraj On Dec. 15, 2022, 1:03 p.m., Dhaval Rajpara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74246/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2022, 1:03 p.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Brijesh Bhalala, > Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Harshal Chavan, jay zalavadia, > Jayendra Parab, Kishore Gopalakrishna, Abhay Kulkarni, Madhan Neethiraj, > Mahesh Bandal, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, Nitin Galave, > Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3537 > https://issues.apache.org/jira/browse/RANGER-3537 > > > Repository: ranger > > > Description > ------- > > As backbone JS is an old library, and its related js library like > backbone-form, backbone-pagination, and backbone table has not been updated > for the last 6 years. Therefore we need to move to the latest and stable UI > framework for Ranger UI. This is critical for security reasons. > > The given review request contains code changes for migrating Ranger Admin UI > to use React JS. > Created a react-webapp directory inside the existing webapp directory to add > the code changes. > > To build a Ranger Admin UI with this changes, please use below mvn command : > > --> mvn clean compile package -DskipTests -Psecurity-admin-react > > > Diffs > ----- > > security-admin/pom.xml f887e03a1 > security-admin/src/main/resources/conf.dist/security-applicationContext.xml > 4ee80b98f > security-admin/src/main/webapp/react-webapp/README.md PRE-CREATION > security-admin/src/main/webapp/react-webapp/babel.config.json PRE-CREATION > security-admin/src/main/webapp/react-webapp/config/paths.js PRE-CREATION > security-admin/src/main/webapp/react-webapp/config/webpack.config.js > PRE-CREATION > security-admin/src/main/webapp/react-webapp/config/webpack.dev.config.js > PRE-CREATION > security-admin/src/main/webapp/react-webapp/config/webpack.prod.config.js > PRE-CREATION > security-admin/src/main/webapp/react-webapp/package-lock.json PRE-CREATION > security-admin/src/main/webapp/react-webapp/package.json PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/App.jsx PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/components/CreatableField.jsx > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/components/structured-filter/main.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/calendar.js > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/date_input.js > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/datepicker.js > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-datepicker/popover.js > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/keyevent.js > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/react-typeahead.js > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/index.js > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/option.js > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/typeahead/selector.js > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/hooks/usePrompt.js > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/hooks/withRouter.js > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/images/cancel_search.png > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/images/defult_zone.png > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/images/error-404-icon.png > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/images/favicon.ico > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/images/folder-grey.png > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/images/ranger_logo.png > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/index.html PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/index.jsx PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/styles/style.css > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/utils/appConstants.js > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/utils/appState.js > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/utils/history.js > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AuditLayout.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/views/Header.jsx > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/views/Home.jsx PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/TestConnection.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/UserGroupRoleListing.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/AddUserView.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx > PRE-CREATION > > > Diff: https://reviews.apache.org/r/74246/diff/3/ > > > Testing > ------- > > 1) Verified CRUD for service/policy/security zone/user/group/roles/permission. > 2) Verified overall Ranger UI with ADMIN,KEY_ADMIN,USER_ROLE,ADMIN_AUDITOR > and KMS_AUDITOR role. > 3) Verified Import/exporting of policies. > 4) Verified report page search. > 5) Verified all the logs under Audit Tab. > > > Thanks, > > Dhaval Rajpara > >
