----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/#review225026 -----------------------------------------------------------
kms/scripts/install.properties Lines 135 (patched) <https://reviews.apache.org/r/74259/#comment313826> Please remove the actual credential from here and provide comments as how it needs to be filled in. The credential seems to be actual AWS keys and works when I issue aws cli command to list-keys. - Selvamohan Neethiraj On Dec. 19, 2022, 2:49 a.m., Kirby Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74259/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2022, 2:49 a.m.) > > > Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, > Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Mateen Mansoori, Mehul > Parikh, Pradeep Agrawal, VaradreawiZTV VaradreawiZTV, Vishal Suvagia, and > Velmurugan Periasamy. > > > Bugs: ranger-3998 > https://issues.apache.org/jira/browse/ranger-3998 > > > Repository: ranger > > > Description > ------- > > AWS KMS is widely used by many customers. > Therefore, RangerKMS should support hosting MasterKey to AWS KMS. > > > Diffs > ----- > > distro/src/main/assembly/kms.xml 4b4a2ac8e > kms/config/kms-webapp/dbks-site.xml 258d331d8 > kms/pom.xml e97b993d7 > kms/scripts/install.properties 0e5da3c75 > kms/scripts/setup.sh f723e09bb > kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java > PRE-CREATION > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java > cb5739f61 > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java > 1f0125967 > > > Diff: https://reviews.apache.org/r/74259/diff/4/ > > > Testing > ------- > > Tested under macos-13 and centos-8 > > > Thanks, > > Kirby Zhou > >