> On 三月 30, 2023, 11:27 a.m., Kishor Gollapalliwar wrote:
> > kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java
> > Lines 24 (patched)
> > <https://reviews.apache.org/r/74259/diff/5/?file=2273861#file2273861line24>
> >
> >     Please consider importing individual classes instead of all.

Can you ship it now?


- Kirby


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74259/#review225323
-----------------------------------------------------------


On 四月 7, 2023, 11:16 a.m., Kirby Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74259/
> -----------------------------------------------------------
> 
> (Updated 四月 7, 2023, 11:16 a.m.)
> 
> 
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, 
> Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Mateen Mansoori, Mehul 
> Parikh, Pradeep Agrawal, VaradreawiZTV VaradreawiZTV, Vishal Suvagia, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: ranger-3998
>     https://issues.apache.org/jira/browse/ranger-3998
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> AWS KMS is widely used by many customers.
> Therefore, RangerKMS should support hosting MasterKey to AWS KMS.
> 
> 
> Diffs
> -----
> 
>   distro/src/main/assembly/kms.xml 4b4a2ac8e15209a8abc0fc72fba464257f585cfc 
>   kms/config/kms-webapp/dbks-site.xml 
> 258d331d82ae4051c261301a6dd1cf980d198ab8 
>   kms/pom.xml e97b993d72a41ffa6d1faaed52666ebf76ee4d5d 
>   kms/scripts/install.properties 0e5da3c756343d655fedf7f286a08d3458b8d6c6 
>   kms/scripts/setup.sh f723e09bbe77f2d9ad064923da42a32f82bb40f1 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java 
> PRE-CREATION 
>   kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 
> 429d1ce45e39c6bb1279a90fedf73776b5b909ba 
>   
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java 
> 1f01259675a536e5e02da51b2b1c9d438314c1de 
> 
> 
> Diff: https://reviews.apache.org/r/74259/diff/6/
> 
> 
> Testing
> -------
> 
> Tested under macos-13 and centos-8
> 
> 
> File Attachments
> ----------------
> 
> 0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
>   
> https://reviews.apache.org/media/uploaded/files/2023/04/07/6499bf0e-af49-4eae-8636-f183f0fab3d7__0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
> 
> 
> Thanks,
> 
> Kirby Zhou
> 
>

Reply via email to