----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74303/#review225174 -----------------------------------------------------------
intg/src/main/python/apache_ranger/client/ranger_client.py Lines 458 (patched) <https://reviews.apache.org/r/74303/#comment313932> Lines 453-458 can also be written as query_params.update(self.query_params) Ideally query_params and self.query_params should not have overlaps but incase they do this would simply overwrite according to the ordering of the update() method. - Abhishek Kumar On Feb. 10, 2023, 10:26 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74303/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2023, 10:26 p.m.) > > > Review request for ranger, Abhishek Kumar, Ankita Sinha, Kishor > Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, > Sailaja Polavarapu, Subhrat Chaudhary, Vishal Gupta, and Velmurugan Periasamy. > > > Bugs: RANGER-4079 > https://issues.apache.org/jira/browse/RANGER-4079 > > > Repository: ranger > > > Description > ------- > > - updated Python client to handle Ranger URLs having subpath > - updated Python client to enable clients to pass headers and query params > > > Diffs > ----- > > intg/src/main/python/apache_ranger/client/ranger_client.py e26528013 > > > Diff: https://reviews.apache.org/r/74303/diff/1/ > > > Testing > ------- > > - verified that Python client successfully work with Ranger URL having subpath > - verified that Python client sends specified query-parameters in each request > > > Thanks, > > Madhan Neethiraj > >
