> On Feb. 11, 2023, 12:36 a.m., Abhishek Kumar wrote: > > intg/src/main/python/apache_ranger/client/ranger_client.py > > Lines 458 (patched) > > <https://reviews.apache.org/r/74303/diff/1/?file=2274624#file2274624line458> > > > > The parameter sent by the caller: query_params gets modified in both > > cases, isn't it so ? > > Madhan Neethiraj wrote: > - query_param.update(): > -- will modify query_param, which will be visible to the caller > - query_param = merged_query_param > -- assigns a new value to query_param. The caller will continue to see > the value they sent in
I understand, thank you for the clarification. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74303/#review225176 ----------------------------------------------------------- On Feb. 10, 2023, 10:26 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74303/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2023, 10:26 p.m.) > > > Review request for ranger, Abhishek Kumar, Ankita Sinha, Kishor > Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, > Sailaja Polavarapu, Subhrat Chaudhary, Vishal Gupta, and Velmurugan Periasamy. > > > Bugs: RANGER-4079 > https://issues.apache.org/jira/browse/RANGER-4079 > > > Repository: ranger > > > Description > ------- > > - updated Python client to handle Ranger URLs having subpath > - updated Python client to enable clients to pass headers and query params > > > Diffs > ----- > > intg/src/main/python/apache_ranger/client/ranger_client.py e26528013 > > > Diff: https://reviews.apache.org/r/74303/diff/1/ > > > Testing > ------- > > - verified that Python client successfully work with Ranger URL having subpath > - verified that Python client sends specified query-parameters in each request > > > Thanks, > > Madhan Neethiraj > >
