-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74349/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj,
Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj,
Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
Bugs: RANGER-4133
https://issues.apache.org/jira/browse/RANGER-4133
Repository: ranger
Description
-------
Apis:
API :addUsersAndGroups
URI:/roles/roles/{id}/addUsersAndGroups
In the API we mentioned a couple of fields (List<String> users, List<String>
groups, Boolean isAdmin).
How the caller will pass the fields
Proposed Solution:
Via query Parameter (Limitation: we can not pass more characters as part of URI
)
Via Request payload of List<String> users, List<String> groups, Boolean isAdmin
–(RangerUsersAndGroups –Modal mentioned above to accommodate users, groups,
isAdmin)
API :removeUsersAndGroups
URI:/roles/roles/{id}/removeUsersAndGroups
In the API we mentioned a couple of fields (List<String> users, List<String>
groups)
How the caller will pass the fields
Proposed Solution:
Via query Parameter (Limitation: we can not pass more characters as part of URI
)
Via Request payload of List<String> users, List<String> groups
(RangerUsersAndGroups –Modal mentioned above to accommodate users,groups)
API :removeAdminFromUsersAndGroups
URI:/roles/roles/{id}/removeUsersAndGroups
In the API we mentioned a couple of fields (List<String> users, List<String>
groups)
How the caller will pass the fields
Proposed Solution:
Via query Parameter (Limitation: we can not pass more characters as part of URI
)
Via Request payload of List<String> users, List<String> groups
(RangerUsersAndGroups –Modal mentioned above to accommodate users, groups)
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerUsersAndGroups.java
PRE-CREATION
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java
85cd7dd67
security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4f0edd2b0
security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java
73a593e9f
security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java
217c1bba3
Diff: https://reviews.apache.org/r/74349/diff/1/
Testing
-------
Thanks,
Ramachandran Krishnan
