----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74494/#review225570 -----------------------------------------------------------
Ship it! Ship It! - Dhaval Rajpara On June 26, 2023, 7:24 a.m., Mugdha Varadkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74494/ > ----------------------------------------------------------- > > (Updated June 26, 2023, 7:24 a.m.) > > > Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Dineshkumar > Yadav, Madhan Neethiraj, and Mehul Parikh. > > > Bugs: RANGER-4301 > https://issues.apache.org/jira/browse/RANGER-4301 > > > Repository: ranger > > > Description > ------- > > Ranger Access Audit doesn't show callerContext in the audit as hover over > button for HDFS audits. > > When HDFS plugins audits are generated some of the audits will have "request > data" which should be shown in the Ranger Audit UI as a hover over button. > Currently it is not happening. > > Looking at the code it looks like acl_enforcer=ranger_acl is the only one > which get to show this. We should not restrict it by acl_enforcer to display > this. > > > Diffs > ----- > > > security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx > 7fe756c47dde1b9df8079e85d6afbcba4647aae1 > security-admin/src/main/webapp/react-webapp/src/styles/style.css > 0d54a20e2584f14bc9e6210131889b8231c3aeff > security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js > 29da52dc6742808c909ea4eab90483596257b9d0 > security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js > 19c600d1af0d3855c63f839a69bc07479cb4ee16 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx > 1b56504328db24f86098c6ab033f0f77f24355c8 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx > b0c44924372308b674138351fa5710862a70803a > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > f4a91939e7a80f586e2daf504804597404646920 > security-admin/src/main/webapp/scripts/utils/XAViewUtils.js > d73a2dfd1a1389879ce1ef023e0fbaa4b152e718 > > security-admin/src/main/webapp/scripts/views/reports/AuditAccessLogDetailView.js > 16e9ef8a40cb6d2ada8b3de20bf57d75e8c10867 > > security-admin/src/main/webapp/templates/reports/AuditAccessLogDetail_tmpl.html > f962b57d0f9d10239f0c0c623e85b822e362ae33 > > > Diff: https://reviews.apache.org/r/74494/diff/1/ > > > Testing > ------- > > Tested changes on a cluster setup with Ranger Admin build with React JS code > base. Also tested the changes on Ranger Admin UI build with Backbone JS code > base. > > Successful completion of build command : > mvn clean compile package -Psecurity-admin-react > > > Thanks, > > Mugdha Varadkar > >
