> On Sept. 21, 2023, 4:06 p.m., Madhan Neethiraj wrote: > > Barbara - the recent update to the review doesn't include the changes. Can > > you please update again?
Yes, I apologize. I'm having trouble generating a new patch: % git format-patch origin/master 0001-doubleBracketsReplace-stuff.patch 0002-added-replaceDoubleBrackets-to-RangerDefaultRowFilte.patch Trying to upload 0002, I get this error: "The uploaded diff uses short revisions, but Review Board requires full revisions. Please generate a new diff using the --full-index parameter." When I do this the result is the same: % git format-patch --full-index origin/master 0001-doubleBracketsReplace-stuff.patch 0002-added-replaceDoubleBrackets-to-RangerDefaultRowFilte.patch snd I get the same error on trying to upload. *** FINALLY, I ADDED THE 0002 FILE UNDER UPDATE DIFF-> ADD FILE. *** I apologize for the inconvenience. - Barbara ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74609/#review225776 ----------------------------------------------------------- On Sept. 18, 2023, 8:36 p.m., Barbara Eckman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74609/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2023, 8:36 p.m.) > > > Review request for ranger and madhan. > > > Repository: ranger > > > Description > ------- > > RANGER-4234: Eliminate need for splitting delimited strings into arrays in > policy conditions > > > Diffs > ----- > > agents-common/dev-support/spotbugsIncludeFile.xml PRE-CREATION > agents-common/pom.xml b753c1368 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > 9e5a94b1a > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java > 7ac20764f > > agents-common/src/main/java/org/apache/ranger/plugin/util/JavaScriptEdits.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/74609/diff/3/ > > > Testing > ------- > > > File Attachments > ---------------- > > 0001-doubleBracketsReplace-stuff.patch > > https://reviews.apache.org/media/uploaded/files/2023/09/18/fe38eef9-22e6-4c91-85a0-46fe337ba87b__0001-doubleBracketsReplace-stuff.patch > 0001-doubleBracketsReplace-stuff.patch > > https://reviews.apache.org/media/uploaded/files/2023/09/18/062f1050-96d7-4ed0-9008-fd65311ea7b0__0001-doubleBracketsReplace-stuff.patch > > > Thanks, > > Barbara Eckman > >
