> On Sept. 21, 2023, 4:06 p.m., Madhan Neethiraj wrote: > > Barbara - the recent update to the review doesn't include the changes. Can > > you please update again? > > Barbara Eckman wrote: > Yes, I apologize. I'm having trouble generating a new patch: > % git format-patch origin/master > 0001-doubleBracketsReplace-stuff.patch > 0002-added-replaceDoubleBrackets-to-RangerDefaultRowFilte.patch > Trying to upload 0002, I get this error: "The uploaded diff uses short > revisions, but Review Board requires full revisions. Please generate a new > diff using the --full-index parameter." > When I do this the result is the same: > % git format-patch --full-index origin/master > 0001-doubleBracketsReplace-stuff.patch > 0002-added-replaceDoubleBrackets-to-RangerDefaultRowFilte.patch > snd I get the same error on trying to upload. > > *** FINALLY, I ADDED THE 0002 FILE UNDER UPDATE DIFF-> ADD FILE. *** I > apologize for the inconvenience.
new DIFF created and posted, to get rid of the confusion. - Barbara ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74609/#review225776 ----------------------------------------------------------- On Sept. 22, 2023, 3:43 p.m., Barbara Eckman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74609/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2023, 3:43 p.m.) > > > Review request for ranger and madhan. > > > Repository: ranger > > > Description > ------- > > RANGER-4234: Eliminate need for splitting delimited strings into arrays in > policy conditions > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultRowFilterPolicyItemEvaluator.java > d2b3e746b > > agents-common/src/main/java/org/apache/ranger/plugin/util/JavaScriptEdits.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/74609/diff/4/ > > > Testing > ------- > > > File Attachments > ---------------- > > 0001-RANGER-4234.patch > > https://reviews.apache.org/media/uploaded/files/2023/09/22/19380bc1-e7ad-4fab-880d-324e38783c05__0001-RANGER-4234.patch > > > Thanks, > > Barbara Eckman > >
