> On Oct. 7, 2023, 11:46 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > > Line 1263 (original), 1263 (patched) > > <https://reviews.apache.org/r/74648/diff/1/?file=2281178#file2281178line1263> > > > > It will be efficient to use x_dataset_policy table to find policies > > associated with a dataset. Consider using > > GdsDBStore.getDatasetPolicies(datasetId).
Addressed review comment. - Subhrat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74648/#review225835 ----------------------------------------------------------- On Oct. 8, 2023, 5:37 p.m., Subhrat Chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74648/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2023, 5:37 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: https://issues.apache.org/jira/browse/RANGER-4463 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4463 > > > Repository: ranger > > > Description > ------- > > With the changes in https://issues.apache.org/jira/browse/RANGER-4445, > dataset name is not getting added in the resources for the dataset policy. > The computation of DatasetSummary.principalsCount is based on getting > policies based on dataset name. The principalsCount is not getting updated in > DatasetSummary. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > dce45729f > > > Diff: https://reviews.apache.org/r/74648/diff/2/ > > > Testing > ------- > > Validated proper prinicpal count from policies - > DatasetSummary.principalsCount, is coming for datasets. > > > Thanks, > > Subhrat Chaudhary > >
