> On Oct. 8, 2023, 6:56 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > > Line 1276 (original), 1275 (patched) > > <https://reviews.apache.org/r/74648/diff/2/?file=2281181#file2281181line1276> > > > > Given getDatasetPolicies(datasetId) at #1270 already returns only > > policies for datasetId, #1275 - #1281 is not necessary. Please review and > > remove.
Addressed review comment. - Subhrat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74648/#review225837 ----------------------------------------------------------- On Oct. 8, 2023, 8:51 p.m., Subhrat Chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74648/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2023, 8:51 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: https://issues.apache.org/jira/browse/RANGER-4463 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4463 > > > Repository: ranger > > > Description > ------- > > With the changes in https://issues.apache.org/jira/browse/RANGER-4445, > dataset name is not getting added in the resources for the dataset policy. > The computation of DatasetSummary.principalsCount is based on getting > policies based on dataset name. The principalsCount is not getting updated in > DatasetSummary. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > dce45729f > > > Diff: https://reviews.apache.org/r/74648/diff/3/ > > > Testing > ------- > > Validated proper prinicpal count from policies - > DatasetSummary.principalsCount, is coming for datasets. > > > Thanks, > > Subhrat Chaudhary > >
