----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74703/#review225914 -----------------------------------------------------------
Ship it! Ship It! - Ramesh Mani On Oct. 28, 2023, 10:40 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74703/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2023, 10:40 a.m.) > > > Review request for ranger, Anand Nadar, Ankita Sinha, Abhay Kulkarni, Mehul > Parikh, Monika Kachhadiya, Mugdha Varadkar, Pradeep Agrawal, Prashant Satam, > Ramesh Mani, Subhrat Chaudhary, Vanita Ubale, and Velmurugan Periasamy. > > > Bugs: RANGER-3815 > https://issues.apache.org/jira/browse/RANGER-3815 > > > Repository: ranger > > > Description > ------- > > - added support for following macros in condition expresion > -- IS_ACCESS_TIME_AFTER > -- IS_ACCESS_TIME_BEFORE > -- IS_ACCESS_TIME_BETWEEN > - this enables policy authors to specify the time period in which > users/groups/roles should be granted/denied access > - example: to grant access to user1 after '2024/01/01 09:00', add condition > IS_ACCESS_TIME_AFTER('2024/01/01 09:00') > - example: to grant access to user1 until '2024/01/01 09:00', add condition > IS_ACCESS_TIME_BEFORE('2024/01/01 09:00') > - example: to grant access to user1 from '2023/10/01 to 2024/01/01', add > condition IS_ACCESS_TIME_BETWEEN('2023/10/01', '2024/01/01') > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java > 884f69137 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java > fa59e8d58 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerTimeRangeChecker.java > PRE-CREATION > > agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java > 6705327d8 > > agents-common/src/test/java/org/apache/ranger/plugin/util/RangerTimeRangeCheckerTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/74703/diff/2/ > > > Testing > ------- > > - added unit tests > - verified that all existing tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
