----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74762/#review226024 -----------------------------------------------------------
Ship it! Ship It! - Ramesh Mani On Nov. 28, 2023, 9:37 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74762/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2023, 9:37 a.m.) > > > Review request for ranger, Ankita Sinha, Abhay Kulkarni, Mehul Parikh, Monika > Kachhadiya, Pradeep Agrawal, Prashant Satam, Ramesh Mani, and Subhrat > Chaudhary. > > > Bugs: RANGER-4302 > https://issues.apache.org/jira/browse/RANGER-4302 > > > Repository: ranger > > > Description > ------- > > - ServiceGdsInfoCache implemented using RangerCache as a refresh-on-access > cache > - updated GdsDBStore.getGdsInfoIfUpdated() to get the latest gdsInfo from > ServiceGdsInfoCache > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/AutoClosableLock.java > 270096a32 > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCache.java > PRE-CREATION > > agents-common/src/test/java/org/apache/ranger/plugin/util/RangerCacheTest.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > 589fcdd68 > > security-admin/src/main/java/org/apache/ranger/common/ServiceGdsInfoCache.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/util/RangerCacheDBValueLoader.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/74762/diff/3/ > > > Testing > ------- > > - verifed that cache loads from the database only if the database has later > version than cached > 2023-11-28 08:25:07,363 [http-nio-6080-exec-1] INFO > [ServiceGdsInfoCache.java:121] Refreshed gdsVersionInfo: > serviceName=dev_yarn, lastKnownVersion=null, latestVersion=1 > 2023-11-28 08:25:08,532 [http-nio-6080-exec-7] INFO > [ServiceGdsInfoCache.java:121] Refreshed gdsVersionInfo: > serviceName=dev_hdfs, lastKnownVersion=null, latestVersion=119 > 2023-11-28 08:25:13,561 [http-nio-6080-exec-3] INFO > [ServiceGdsInfoCache.java:121] Refreshed gdsVersionInfo: > serviceName=dev_hive, lastKnownVersion=null, latestVersion=118 > 2023-11-28 08:26:07,606 [ranger-cache-1-ServiceGdsInfoCache1] INFO > [ServiceGdsInfoCache.java:125] No change in gdsVersionInfo: > serviceName=dev_yarn, lastKnownVersion=1, latestVersion=1 > 2023-11-28 08:26:08,614 [ranger-cache-1-ServiceGdsInfoCache2] INFO > [ServiceGdsInfoCache.java:125] No change in gdsVersionInfo: > serviceName=dev_hdfs, lastKnownVersion=119, latestVersion=119 > 2023-11-28 08:26:13,817 [ranger-cache-1-ServiceGdsInfoCache1] INFO > [ServiceGdsInfoCache.java:125] No change in gdsVersionInfo: > serviceName=dev_hive, lastKnownVersion=118, latestVersion=118 > ... > 2023-11-28 09:24:24,514 [ranger-cache-1-ServiceGdsInfoCache1] INFO > [ServiceGdsInfoCache.java:125] No change in gdsVersionInfo: > serviceName=dev_yarn, lastKnownVersion=1, latestVersion=1 > 2023-11-28 09:24:25,761 [ranger-cache-1-ServiceGdsInfoCache2] INFO > [ServiceGdsInfoCache.java:121] Refreshed gdsVersionInfo: > serviceName=dev_hdfs, lastKnownVersion=119, latestVersion=120 > 2023-11-28 09:24:30,960 [ranger-cache-1-ServiceGdsInfoCache1] INFO > [ServiceGdsInfoCache.java:121] Refreshed gdsVersionInfo: > serviceName=dev_hive, lastKnownVersion=118, latestVersion=120 > - verified that plugin calls to download GDS info receive the latest version > > > Thanks, > > Madhan Neethiraj > >
