----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75015/#review226497 -----------------------------------------------------------
Please make sure to run 'mvn clean verify' and address PMD violations (missing license text, unused imports). agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java Line 83 (original), 83 (patched) <https://reviews.apache.org/r/75015/#comment314693> Consider using ThreadLocal<ObjectMapper>, similar to JsonUtilsV2. agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java Lines 96 (patched) <https://reviews.apache.org/r/75015/#comment314692> Currently Gson date format 'yyyyMMdd-HH:mm:ss.SSS-Z' is used - see line #138 in BaseAuditHandler.java. Please ensure that the format specified here produces the same output as the current version. agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileCacheProviderSpool.java Line 127 (original), 144 (patched) <https://reviews.apache.org/r/75015/#comment314696> To avoid code duplication, consider replacing objectMapper with use of methods in MiscUtil. agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileQueueSpool.java Line 142 (original), 141 (patched) <https://reviews.apache.org/r/75015/#comment314695> To avoid code duplication, consider replacing objectMapper with use of methods in MiscUtil. MiscUtil.stringify(). agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java Line 137 (original), 136 (patched) <https://reviews.apache.org/r/75015/#comment314697> To avoid code duplication, consider replacing objectMapper with use of methods in MiscUtil. MiscUtil.stringify(). agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java Line 53 (original), 56 (patched) <https://reviews.apache.org/r/75015/#comment314698> To avoid code duplication, consider replacing objectMapper with use of methods in JsonUtils. agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java Line 884 (original), 886 (patched) <https://reviews.apache.org/r/75015/#comment314699> To avoid code duplication, consider replacing objectMapper with use of methods in JsonUtils. agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreRefresher.java Line 61 (original), 62 (patched) <https://reviews.apache.org/r/75015/#comment314700> To avoid code duplication, consider replacing objectMapper with use of methods in JsonUtils. agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/externalretrievers/GetFromURL.java Line 54 (original), 57 (patched) <https://reviews.apache.org/r/75015/#comment314701> To avoid code duplication, consider replacing objectMapper with use of methods in JsonUtils. agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java Line 132 (original), 134 (patched) <https://reviews.apache.org/r/75015/#comment314702> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java Line 61 (original), 60 (patched) <https://reviews.apache.org/r/75015/#comment314703> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java Line 190 (original), 192 (patched) <https://reviews.apache.org/r/75015/#comment314704> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java Line 105 (original), 107 (patched) <https://reviews.apache.org/r/75015/#comment314705> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRolesProvider.java Line 52 (original), 53 (patched) <https://reviews.apache.org/r/75015/#comment314706> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java Line 161 (original), 163 (patched) <https://reviews.apache.org/r/75015/#comment314707> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java Lines 91 (patched) <https://reviews.apache.org/r/75015/#comment314708> Can the text contain any other offset like 0800, 0530? If the intention is to replace "-+" with "+", is it necessary to look for "-+0000"? security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java Lines 106 (patched) <https://reviews.apache.org/r/75015/#comment314709> Aren't these additional setup for Date (serialization options, and deserialization) not needed in ObjectMapper instances in MiscUtil and JsonUtil? security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java Lines 399 (patched) <https://reviews.apache.org/r/75015/#comment314710> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java Line 59 (original), 61 (patched) <https://reviews.apache.org/r/75015/#comment314711> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. security-admin/src/main/java/org/apache/ranger/db/XXGroupDao.java Line 134 (original), 133 (patched) <https://reviews.apache.org/r/75015/#comment314712> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java Line 204 (original), 205 (patched) <https://reviews.apache.org/r/75015/#comment314713> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. security-admin/src/main/java/org/apache/ranger/patch/PatchForSyncSourceUpdate_J10054.java Line 93 (original), 96 (patched) <https://reviews.apache.org/r/75015/#comment314714> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. security-admin/src/main/java/org/apache/ranger/patch/PatchForXGlobalState_J10036.java Line 75 (original), 78 (patched) <https://reviews.apache.org/r/75015/#comment314715> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java Lines 122 (patched) <https://reviews.apache.org/r/75015/#comment314716> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java Line 48 (original), 50 (patched) <https://reviews.apache.org/r/75015/#comment314717> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java Line 68 (original), 67 (patched) <https://reviews.apache.org/r/75015/#comment314718> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. tagsync/src/main/java/org/apache/ranger/tagsync/model/AbstractTagSource.java Lines 36 (patched) <https://reviews.apache.org/r/75015/#comment314719> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java Line 284 (original), 284 (patched) <https://reviews.apache.org/r/75015/#comment314720> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java Line 233 (original), 233 (patched) <https://reviews.apache.org/r/75015/#comment314721> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. tagsync/src/main/java/org/apache/ranger/tagsync/source/file/FileTagSource.java Line 48 (original), 49 (patched) <https://reviews.apache.org/r/75015/#comment314722> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java Line 268 (original), 269 (patched) <https://reviews.apache.org/r/75015/#comment314723> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java Lines 155 (patched) <https://reviews.apache.org/r/75015/#comment314724> To avoid code duplication, consider replacing objectMapper with use of appropriate methods in JsonUtils. - Madhan Neethiraj On May 28, 2024, 4:11 p.m., Monika Kachhadiya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75015/ > ----------------------------------------------------------- > > (Updated May 28, 2024, 4:11 p.m.) > > > Review request for ranger, Anand Nadar, Asit Vadhavkar, Madhan Neethiraj, > Siddhesh Phatak, and Subhrat Chaudhary. > > > Bugs: RANGER-4806 > https://issues.apache.org/jira/browse/RANGER-4806 > > > Repository: ranger > > > Description > ------- > > The root as mentioned here: > https://github.com/google/gson/issues/1979#issuecomment-927943566 > > Similar to #1963 and other existing reports. Apparently you are deserializing > a JDK class (java.security.KeyFactory) without having specified a custom type > adapter for it. Gson will then by default use a reflection based type > adapter. You have to write a custom type adapter to solve this issue or move > to jackson fasterxml. > > This patch is to move from Gson to jackson fasterxml. > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/model/AuditIndexRecord.java > PRE-CREATION > > agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java > 2e32fb5794321deb400956b840968653e76e8d0d > > agents-audit/src/main/java/org/apache/ranger/audit/model/SPOOL_FILE_STATUS.java > PRE-CREATION > > agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java > 68c33c90dbf0e3581f13a8b55aa4d0f2fa8ec11f > agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java > 1e5d1d8d8e7811e6f1c1fe4127f3d5f29ec71f25 > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileCacheProviderSpool.java > bc8f685c3b5fa81c8005fa71a8e670b73bb2650c > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileQueueSpool.java > 26e11aba99ac1fae017a2dc3c82ad801070e7446 > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java > 3f40861b06e0b1a29950472cd70ec0f0aa681165 > agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCFileUtil.java > f73df2c207f5112a8a1966778efff7a6109cd8ab > > agents-common/src/main/java/org/apache/ranger/authorization/utils/JsonUtils.java > 8113e4280f25bc80d6ae520d5aae9fa771bac066 > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java > df2c7ccf152bd46ef9ca60ca3fab7e641b52a48d > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > c5f5fc3be61fafdd581c9a2f911982bd1480d75b > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreRefresher.java > fe0b923341ed49783830c922ecb2fa5bf7249a0a > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/externalretrievers/GetFromURL.java > f9eae35747ff12e5d18f03eeed36b346bab19db0 > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java > 92ce183bbd35589b79d3f081d18a3f1b0ab9bd5c > > agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java > aa0c801199cb6e50b0b307471e5579f762721c89 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java > 588605a6ac6f78ecf41f0094614f15f588ac7cab > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java > e54313403d2207cf82838f4cae4ead63dee38069 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRolesProvider.java > 58a47cf1b07f88f06304a9ff8f4272c5e84e700a > security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java > c9a9987c8694379ac740a10f69ff07412fac7e66 > > security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java > 321148307c0b9d87befd17a1b044e53915f91106 > security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java > a15ceac56184c3d626294248b22fe06a4e694e64 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 7ac16a9eeeaa14e1e24a2e839afeb1f23ec8dd7c > security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java > 63bde37d8bf087899696bc562194047317a7f2f3 > > security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java > c768f1c3464776c3e9ac38cd94ae50635e048920 > security-admin/src/main/java/org/apache/ranger/db/XXGroupDao.java > f910e92ee53ed0e443f7dd757dcc232773e0d44b > security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java > 8af4448b5db7a4c0a7ae047d6abf57dbcf091564 > > security-admin/src/main/java/org/apache/ranger/patch/PatchForSyncSourceUpdate_J10054.java > 99de47310a65357e1abf178ef53ae6f702d1367f > > security-admin/src/main/java/org/apache/ranger/patch/PatchForXGlobalState_J10036.java > 5506625bce6fd9c4c9228c872b046412ff9196f2 > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java > 7d4828ed004717bb2fe029494fa6d3ec16ef6b81 > security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java > b35b8af6589c49e14f5a74437171f7851b934781 > > security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java > b815b1d37b549feb1220102be5c0b56a92086b9a > > security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java > 48be2b5fe6deb661aa1e6af557d2ad51d56103f7 > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceService.java > 918c8d0091f757987e7ae2be5116a5578bf5bf05 > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceWithTagsService.java > 2b3acd17a761247b07a0c9ee97b0e658c45b1485 > > security-admin/src/main/java/org/apache/ranger/service/RangerTagDefService.java > c779b774663c280e197bd41772b1855c3e184d50 > > security-admin/src/main/java/org/apache/ranger/service/RangerTagService.java > fe79c3e5f0c3fd966a773492f3c6828880710317 > > tagsync/src/main/java/org/apache/ranger/tagsync/model/AbstractTagSource.java > ff9937628fd7b3e86e7b1643eb9fe9315c1b7dea > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java > 9a761b33c3733a40a16530e25534d089a8294c7e > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java > 792ced1329902ff02d55ad90ed1822c8af958323 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/file/FileTagSource.java > 65deccd14aac50459bb84c756f31ddf052a13bf2 > > ugsync/src/main/java/org/apache/ranger/unixusersync/model/GetXGroupListResponse.java > c0e8a0986a0965739a504478147d06ba870e2531 > > ugsync/src/main/java/org/apache/ranger/unixusersync/model/GetXUserListResponse.java > 16ad7d6e4437f9f69397f6eada79d50a2b52043c > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java > 9c951a668508d170a0f78b9baccac1a409e1908a > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > fecd96de01b1fd9b7ecc2a24ea1d3c554ed79ef5 > > > Diff: https://reviews.apache.org/r/75015/diff/1/ > > > Testing > ------- > > Sanity test of CRUD policies/users/groups from ranger UI > Verified existing junits test cases are working as expected > verified audit spool is generated as expected in case of java 17 > > > Thanks, > > Monika Kachhadiya > >
