----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75015/#review226541 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/authorization/utils/JsonUtils.java Lines 61-63 (original), 67-76 (patched) <https://reviews.apache.org/r/75015/#comment314785> MiscUtil.getMapper() returns same JSON objectMapper. We can resue that here and JsonUtils.getMapper() can return same: ObjectMapper jsonMapper = MiscUtil.getMapper(); This way we have mapper init in one place. agents-common/src/main/java/org/apache/ranger/authorization/utils/JsonUtils.java Lines 147 (patched) <https://reviews.apache.org/r/75015/#comment314788> Error message is incorrect: objectToWriter() failed to write object to writer: object agents-common/src/main/java/org/apache/ranger/authorization/utils/JsonUtils.java Line 123 (original), 186 (patched) <https://reviews.apache.org/r/75015/#comment314786> Method name in error message should be jsonToMapStringString - Subhrat Chaudhary On June 3, 2024, 10:44 p.m., Monika Kachhadiya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75015/ > ----------------------------------------------------------- > > (Updated June 3, 2024, 10:44 p.m.) > > > Review request for ranger, Anand Nadar, Asit Vadhavkar, Madhan Neethiraj, > Siddhesh Phatak, and Subhrat Chaudhary. > > > Bugs: RANGER-4806 > https://issues.apache.org/jira/browse/RANGER-4806 > > > Repository: ranger > > > Description > ------- > > The root as mentioned here: > https://github.com/google/gson/issues/1979#issuecomment-927943566 > > Similar to #1963 and other existing reports. Apparently you are deserializing > a JDK class (java.security.KeyFactory) without having specified a custom type > adapter for it. Gson will then by default use a reflection based type > adapter. You have to write a custom type adapter to solve this issue or move > to jackson fasterxml. > > This patch is to move from Gson to jackson fasterxml. > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/model/AuditIndexRecord.java > PRE-CREATION > > agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java > 2e32fb5794 > > agents-audit/src/main/java/org/apache/ranger/audit/model/SPOOL_FILE_STATUS.java > PRE-CREATION > > agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java > 68c33c90db > agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java > 1e5d1d8d8e > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileCacheProviderSpool.java > bc8f685c3b > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileQueueSpool.java > 26e11aba99 > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java > 3f40861b06 > agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCFileUtil.java > f73df2c207 > > agents-common/src/main/java/org/apache/ranger/authorization/utils/JsonUtils.java > 8113e4280f > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java > df2c7ccf15 > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > c5f5fc3be6 > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreRefresher.java > fe0b923341 > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/externalretrievers/GetFromURL.java > f9eae35747 > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java > 92ce183bbd > > agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java > aa0c801199 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java > 588605a6ac > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java > e54313403d > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRolesProvider.java > 58a47cf1b0 > security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java > c9a9987c86 > > security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java > 321148307c > security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java > a15ceac561 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 7ac16a9eee > security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java > 63bde37d8b > > security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java > c768f1c346 > security-admin/src/main/java/org/apache/ranger/db/XXGroupDao.java > f910e92ee5 > security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 8af4448b5d > > security-admin/src/main/java/org/apache/ranger/patch/PatchForSyncSourceUpdate_J10054.java > 99de47310a > > security-admin/src/main/java/org/apache/ranger/patch/PatchForXGlobalState_J10036.java > 5506625bce > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java > 7d4828ed00 > security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java > b35b8af658 > > security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java > b815b1d37b > > security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java > 48be2b5fe6 > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceService.java > 918c8d0091 > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceWithTagsService.java > 2b3acd17a7 > > security-admin/src/main/java/org/apache/ranger/service/RangerTagDefService.java > c779b77466 > > security-admin/src/main/java/org/apache/ranger/service/RangerTagService.java > fe79c3e5f0 > > tagsync/src/main/java/org/apache/ranger/tagsync/model/AbstractTagSource.java > ff9937628f > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java > 9a761b33c3 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java > 792ced1329 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/file/FileTagSource.java > 65deccd14a > > ugsync/src/main/java/org/apache/ranger/unixusersync/model/GetXGroupListResponse.java > c0e8a0986a > > ugsync/src/main/java/org/apache/ranger/unixusersync/model/GetXUserListResponse.java > 16ad7d6e44 > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java > 9c951a6685 > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > fecd96de01 > > > Diff: https://reviews.apache.org/r/75015/diff/2/ > > > Testing > ------- > > Sanity test of CRUD policies/users/groups from ranger UI > Verified existing junits test cases are working as expected > verified audit spool is generated as expected in case of java 17 > > > Thanks, > > Monika Kachhadiya > >
