----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75013/#review226516 -----------------------------------------------------------
Ship it! Ship It! - Brijesh Bhalala On June 6, 2024, 11:07 a.m., Dhaval Rajpara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75013/ > ----------------------------------------------------------- > > (Updated June 6, 2024, 11:07 a.m.) > > > Review request for ranger, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, > Kishor Gollapalliwar, Madhan Neethiraj, Mugdha Varadkar, Pradeep Agrawal, and > Velmurugan Periasamy. > > > Bugs: RANGER-4774 > https://issues.apache.org/jira/browse/RANGER-4774 > > > Repository: ranger > > > Description > ------- > > 1) UI popup showing details of an admin audit log seems to have hardcoded > string “Indian Standard Time” > 2)Some logs table header also have hardcoded string “Indian Standard Time” > > > Diffs > ----- > > security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js d189e4aeb > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx > 47407fd08 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx > 9ebc90290 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx > c67369e84 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx > 6b2143adb > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx > d7aabf8dc > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx > 08c0082c1 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx > 5f3552954 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx > 1372f2258 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx > aa358fd95 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx > 81b7ce486 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx > d7ee72db9 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx > a2b24f089 > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx > 105659759 > > > Diff: https://reviews.apache.org/r/75013/diff/1/ > > > Testing > ------- > > In the Ranger React UI, several modules displayed hardcoded time zone strings > ("Indian Standard Time"). Tests were conducted to ensure audit logs across > different operations display the correct timestamps reflecting the > appropriate time zone. The verification included: > > 1) Services: Timestamps for created, updated, and deleted services. > 2) Policies: Timestamps for created, updated, and deleted access, masking, > row-level, and tag policies. > 3) Users/Groups/Roles: Timestamps for created, updated, and deleted users, > groups, and roles, including user password changes. > 4)Security Zones: Timestamps for created, updated, and deleted security zones. > 5) Audits: Correct time zone display in the admin, login session, and plugins > tabs, as well as Usersync's sync time. > 6) Export/Import: Correct times and time zones in logs for exported and > imported policies. > 7) Reports: Export times in various file formats adapting to the selected > time zone, and consistency of log times across different time zones. > > > Thanks, > > Dhaval Rajpara > >
