-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75033/
-----------------------------------------------------------
(Updated June 6, 2024, 9:13 p.m.)
Review request for ranger, Abhishek Kumar, Fateh Singh, Abhay Kulkarni, Mugdha
Varadkar, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan
Periasamy.
Summary (updated)
-----------------
RANGER-4811: updated Trino plugin code to be compliant with coding standards of
Trino project
Bugs: RANGER-4811
https://issues.apache.org/jira/browse/RANGER-4811
Repository: ranger
Description
-------
Trino project has several requirements for the code in their repo, including:
- placement of '{' in different contexts
- ordering of items in pom.xml
- use of white spaces
This patch has updates to the Trino plugin to be complaint with such
requirements.
Diffs
-----
plugin-trino/pom.xml 1cd35e987
plugin-trino/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java
c440bf394
plugin-trino/src/main/java/org/apache/ranger/services/trino/RangerServiceTrino.java
bead9e0c9
plugin-trino/src/main/java/org/apache/ranger/services/trino/client/TrinoClient.java
1567b2d1d
plugin-trino/src/main/java/org/apache/ranger/services/trino/client/TrinoConnectionManager.java
6afd8f417
plugin-trino/src/main/java/org/apache/ranger/services/trino/client/TrinoResourceManager.java
2d32068a6
plugin-trino/src/test/java/org/apache/ranger/authorization/trino/authorizer/RangerAdminClientImpl.java
af74fc642
plugin-trino/src/test/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlTest.java
eda87db4e
ranger-trino-plugin-shim/pom.xml 9e166dd1e
ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerConfig.java
8fc6d5c1b
ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java
10418dabb
ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControlFactory.java
2d694ac17
ranger-trino-plugin-shim/src/main/java/org/apache/ranger/authorization/trino/authorizer/TrinoRangerPlugin.java
aa6ce8620
Diff: https://reviews.apache.org/r/75033/diff/1/
Testing
-------
- verified that the updated plugin code builds in Trino repo
- verified using docker setup that Trino server starts successfully with the
updated Trino plugin, and the plugin enforces Ranger policies
Thanks,
Madhan Neethiraj
