----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75004/ -----------------------------------------------------------
(Updated July 10, 2024, 8:16 a.m.) Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy. Changes ------- Addressed review comments. Bugs: RANGER-4795 https://issues.apache.org/jira/browse/RANGER-4795 Repository: ranger Description (updated) ------- There is an inconsistency between Ranger API and UI not doing the same validation for Policy creation. Policy creation API should fail when a policy with all empty values and along with [""] or ["null"] in policyItem --> users, groups and roles. Similar validation should be applied for data masking Policy. Diffs (updated) ----- agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java d73d91b36 Diff: https://reviews.apache.org/r/75004/diff/4/ Changes: https://reviews.apache.org/r/75004/diff/3-4/ Testing (updated) ------- Verified while creating/updating Policy API fails, when users, groups, roles and data masking fields are all empty values or contain arrays with empty strings (e.g. [""]) within the policy items. Thanks, Rakesh Gupta