----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75004/#review227167 -----------------------------------------------------------
Ship it! Ship It! - Dineshkumar Yadav On Jan. 6, 2025, 2:29 p.m., Rakesh Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75004/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2025, 2:29 p.m.) > > > Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, > sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-4795 > https://issues.apache.org/jira/browse/RANGER-4795 > > > Repository: ranger > > > Description > ------- > > There is an inconsistency between Ranger API and UI not doing the same > validation for Policy creation. > > Policy creation API should fail when a policy with all empty values and along > with [""] or ["null"] in policyItem --> users, groups and roles. > > Similar validation should be applied for data masking Policy. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java > 82ba483aa > > > Diff: https://reviews.apache.org/r/75004/diff/6/ > > > Testing > ------- > > Verified while creating/updating Policy API fails, when users, groups, roles > and data masking fields are all empty values or contain arrays with empty > strings (e.g. [""]) within the policy items. > > > Thanks, > > Rakesh Gupta > >
