-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75208/#review226915
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java
Line 1043 (original), 1067 (patched)
<https://reviews.apache.org/r/75208/#comment315196>

    Nit: Please correct the indent.You can use tab instead of space? looks like 
some mismatch in what was earlier



security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java
Lines 1142 (patched)
<https://reviews.apache.org/r/75208/#comment315195>

    RangerAPIList.REMOVE_SHARED_RESOURCE this can be change to 
RangerAPIList.REMOVE_SHARED_RESOURCES. Add a new entry in RangerAPIList



security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java
Line 1107 (original), 1149 (patched)
<https://reviews.apache.org/r/75208/#comment315194>

    Nit: Please correct the indent.You can use tab instead of space? looks like 
some mismatch in what was earlier


- Ramesh Mani


On Sept. 16, 2024, 7:14 p.m., Radhika Kundam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75208/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2024, 7:14 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Ramesh Mani.
> 
> 
> Bugs: RANGER-4934
>     https://issues.apache.org/jira/browse/RANGER-4934
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Ranger API to add and delete assets to the DataShare in bulk. Current API 
> accepts only one resource and has to support adding / deleting multiple 
> resources.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java b1a00533e 
> 
> 
> Diff: https://reviews.apache.org/r/75208/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually.
> 
> 
> File Attachments
> ----------------
> 
> API details
>   
> https://reviews.apache.org/media/uploaded/files/2024/09/16/a4540abb-1c2d-471e-bbd3-eb74a8756159__Multiple_resources_add_delete_API_details.json
> 
> 
> Thanks,
> 
> Radhika Kundam
> 
>

Reply via email to