----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75239/#review226988 -----------------------------------------------------------
Fix it, then Ship it! agents-common/src/test/resources/policyengine/hbaseTags.json Lines 57 (patched) <https://reviews.apache.org/r/75239/#comment315270> nit: finance.professional-guid => finance.personal-guid agents-common/src/test/resources/policyengine/test_policyengine_tag_hbase.json Lines 24 (patched) <https://reviews.apache.org/r/75239/#comment315269> This policy item seems unnecessary; I suggest removing it. agents-common/src/test/resources/policyengine/test_policyengine_tag_hbase.json Lines 152 (patched) <https://reviews.apache.org/r/75239/#comment315271> Append 'with scope=SELF_OR_DESCENDANTS' to test name. - Madhan Neethiraj On Oct. 22, 2024, 6:16 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75239/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2024, 6:16 p.m.) > > > Review request for ranger, Dineshkumar Yadav, madhan, Madhan Neethiraj, Mehul > Parikh, Velmurugan Periasamy, and Vyom Tiwari. > > > Bugs: RANGER-4922 > https://issues.apache.org/jira/browse/RANGER-4922 > > > Repository: ranger > > > Description > ------- > > Previous patch for RANGER-4922 does not handle request with > resourceMatchingScope set to SELF_OR_DESCENDANT. This patch fixes it. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > 92d2a7848 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > 34f1f07f4 > agents-common/src/test/resources/policyengine/hbaseTags.json PRE-CREATION > > agents-common/src/test/resources/policyengine/test_policyengine_tag_hbase.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/75239/diff/1/ > > > Testing > ------- > > Added a unit test for request with resourceMatchingScope set to > SELF_OR_DESCENDANT. > > Ran all unit tests successfully. > > > Thanks, > > Abhay Kulkarni > >
