----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75271/#review227110 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java Lines 553 (patched) <https://reviews.apache.org/r/75271/#comment315393> Consider replacing #553 with the following, for better readability. Also, rename getPoliciesWithMetaAttributesIfNeeded() => getPoliciesWithMetaAttributes(). if (includeMetaAttributes) { ret = seviceREST.getPoliciesWithMetaAttributes(ret); } ... return ret; - Madhan Neethiraj On Nov. 26, 2024, 7:17 a.m., Guru Thejus Arveti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75271/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2024, 7:17 a.m.) > > > Review request for ranger, Madhan Neethiraj and Pradeep Agrawal. > > > Bugs: RANGER-4996 > https://issues.apache.org/jira/browse/RANGER-4996 > > > Repository: ranger > > > Description > ------- > > RANGER-4996: Made meta attributes fields in policy rest api response > configurable for retrieval > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java > 97072391e > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 0dee87734 > > security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java > c8d1e5d08 > security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java > c65b961fc > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java > b93b63f85 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > ce3a95766 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 1a2acd188 > > > Diff: https://reviews.apache.org/r/75271/diff/3/ > > > Testing > ------- > > Tested the /service/public/v2/api/policy rest api from swagger and as well as > from postman and verified that createTime, updateTime, createdBy, updatedBy > fields are being retrieved in the response when the > ranger.admin.api.include.policy.meta.attributes flag is set > > > Thanks, > > Guru Thejus Arveti > >
