vyommani commented on code in PR #748:
URL: https://github.com/apache/ranger/pull/748#discussion_r2572832140
##########
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java:
##########
@@ -4298,6 +4308,45 @@ private RangerPolicyList
toRangerPolicyList(List<RangerPolicy> policyList, Searc
return ret;
}
+ private List<RangerPolicy> getRangerPoliciesInRange(List<RangerPolicy>
policyList, SearchFilter filter) {
+ List<RangerPolicy> retList = null;
+ if (CollectionUtils.isNotEmpty(policyList)) {
+ int totalCount = policyList.size();
+ int startIndex = filter.getBeginIndex();
+ int pageSize = filter.getOffset();
+ int toIndex = Math.min(startIndex + pageSize, totalCount);
+ LOG.info("==>totalCount: {}, startIndex:{}, pageSize: {}, toIndex:
{}" , totalCount, startIndex, pageSize, toIndex);
+ String sortType = filter.getSortType();
+ String sortBy = filter.getSortBy();
+
+ if (StringUtils.isNotEmpty(sortBy) &&
StringUtils.isNotEmpty(sortType)) {
+ // By default policyList is sorted by policyId in asc order,
So handling only desc case.
+ if (SearchFilter.POLICY_ID.equalsIgnoreCase(sortBy)) {
+ if (SORT_ORDER.DESC.name().equalsIgnoreCase(sortType)) {
+ policyList.sort(this.getPolicyComparator(sortBy,
sortType));
+ }
+ } else if (SearchFilter.POLICY_NAME.equalsIgnoreCase(sortBy)) {
+ if (SORT_ORDER.ASC.name().equalsIgnoreCase(sortType)) {
+ policyList.sort(this.getPolicyComparator(sortBy,
sortType));
+ } else if
(SORT_ORDER.DESC.name().equalsIgnoreCase(sortType)) {
+ policyList.sort(this.getPolicyComparator(sortBy,
sortType));
+ } else {
+ LOG.info("Invalid or Unsupported sortType : {}",
sortType);
+ }
+ } else {
+ LOG.info("Invalid or Unsupported sortBy property : {}" ,
sortBy);
+ }
+ }
+
+ retList = new ArrayList<RangerPolicy>();
Review Comment:
This manual copying can be simplified using subList(). You could either
create a new list with new ArrayList<>(policyList.subList(startIndex, toIndex))
or return the sublist view directly. I'd recommend creating a new list to avoid
exposing a mutable reference to the internal collection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
