mneethiraj commented on code in PR #824:
URL: https://github.com/apache/ranger/pull/824#discussion_r2734935111
##########
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java:
##########
@@ -2964,6 +2964,9 @@ public int
createOrDeleteXGroupUserList(List<GroupUserInfo> groupUserInfoList) {
updatedGroups = groupUserInfoList.size();
Review Comment:
Looking at implementation of
`xGroupUserService.createOrDeleteXGroupUsers()`, no update might be performed
in some scenarios - depending on contents of parameter `groupUserInfo`. I
suggest updating this method to return `true` when it performs any update and
use that to increment `updatedGroups`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
