kimsehwan96 commented on code in PR #824:
URL: https://github.com/apache/ranger/pull/824#discussion_r2736615489


##########
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java:
##########
@@ -2964,6 +2964,9 @@ public int 
createOrDeleteXGroupUserList(List<GroupUserInfo> groupUserInfoList) {
 
                 updatedGroups = groupUserInfoList.size();

Review Comment:
   By the way, returning boolean with name `createOrDeleteXGroupUsers` might be 
little awkward



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to