Copilot commented on code in PR #960:
URL: https://github.com/apache/ranger/pull/960#discussion_r3281896700
##########
.github/workflows/ci.yml:
##########
@@ -30,7 +30,7 @@ on:
branches: [ "master" ]
env:
- MAVEN_OPTS: -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
-Dmaven.wagon.http.retryHandler.class=standard
-Dmaven.wagon.http.retryHandler.count=3
+ MAVEN_OPTS: -Xmx5g -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
-Dmaven.wagon.http.retryHandler.class=standard
-Dmaven.wagon.http.retryHandler.count=3
Review Comment:
Setting MAVEN_OPTS to -Xmx5g in GitHub-hosted runners (ubuntu-22.04) leaves
limited headroom for the OS, Surefire forks, and other processes, which can
lead to OOM-killed builds. Consider a smaller heap (e.g., 3–4g) and/or reducing
Maven parallelism (-T) if the goal is to improve CI stability.
##########
.github/workflows/ci.yml:
##########
@@ -30,7 +30,7 @@ on:
branches: [ "master" ]
env:
- MAVEN_OPTS: -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
-Dmaven.wagon.http.retryHandler.class=standard
-Dmaven.wagon.http.retryHandler.count=3
+ MAVEN_OPTS: -Xmx5g -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
-Dmaven.wagon.http.retryHandler.class=standard
-Dmaven.wagon.http.retryHandler.count=3
Review Comment:
The PR description focuses on fixing a Docker-triggered build failure, but
this workflow change alters GitHub Actions Maven JVM settings as well. Either
update the PR description to explicitly include the CI memory change (and why
it’s needed) or move this adjustment to a separate PR to keep scope clear.
##########
dev-support/ranger-docker/scripts/build/ranger-build.sh:
##########
@@ -44,7 +44,7 @@ then
BUILD_HOST_SRC=true
fi
-export MAVEN_OPTS="-Xms2g -Xmx2g"
+export MAVEN_OPTS="-Xms512m -Xmx5g -XX:+UseG1GC
-XX:+ExplicitGCInvokesConcurrent -XX:SoftRefLRUPolicyMSPerMB=50 ${JAVA_OPTS}"
Review Comment:
This change hardcodes several non-default JVM tuning flags (G1GC,
ExplicitGCInvokesConcurrent, SoftRefLRUPolicyMSPerMB) without any in-script
rationale. Since these flags can be JVM-version sensitive and make future
troubleshooting harder, consider limiting this to the heap size change (or add
a brief comment explaining why each flag is required for the Docker build).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
