Copilot commented on code in PR #995:
URL: https://github.com/apache/ranger/pull/995#discussion_r3398371434
##########
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx:
##########
@@ -466,10 +500,24 @@ export default function PolicyPermissionItem(props) {
{...input}
placement="auto"
type="custom"
-
conditionDefVal={policyConditionUpdatedJSON(
- serviceCompDetails.policyConditions
- )}
- selectProps={{ isMulti: true }}
+ conditionDefVal={conditionDefVal}
+
servicedefName={serviceCompDetails?.name}
+ actionFilterContext={{
+ selectedAccessTypes:
+
getSelectedAccessTypesForRow(formValues, attrName, index),
+ leafResourceTypes,
+ accessTypeDefs:
+ serviceCompDetails?.accessTypes
+ }}
+ selectProps={{
+ isMulti: true,
+ // Portal menus to body (see
Editable CONDITION_POPOVER_SELECT_PROPS)
+ // so a long Action list with ALL
permission does not jump the page.
+ menuPortalTarget: document.body,
Review Comment:
`menuPortalTarget: document.body` will throw a ReferenceError in non-browser
environments (SSR/unit tests) and also overrides Editable’s guarded default.
Guard the `document` reference (or omit `menuPortalTarget` here and let
Editable’s CONDITION_POPOVER_SELECT_PROPS handle it).
##########
pom.xml:
##########
@@ -892,6 +892,11 @@
<name>jetbrains-intellij-dependencies</name>
<url>https://packages.jetbrains.team/maven/p/ij/intellij-dependencies</url>
</repository>
+ <repository>
+ <id>apache-ozone-staging</id>
+ <name>Apache Ozone 2.1.1 RC0 Staging</name>
+
<url>https://repository.apache.org/content/repositories/orgapacheozone-1062/</url>
+ </repository>
Review Comment:
The root POM adds an Apache repository URL that appears to be a staging/RC
repository (`repository.apache.org/content/repositories/...`). Depending on an
RC/staging repo in the default build is brittle (repo can be removed or
artifacts can change), and it affects all downstream consumers/build
environments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
