Copilot commented on code in PR #1052:
URL: https://github.com/apache/ranger/pull/1052#discussion_r3539865078
##########
agents-common/pom.xml:
##########
@@ -182,6 +182,7 @@
<groupId>org.graalvm.js</groupId>
<artifactId>js</artifactId>
<version>${graalvm.version}</version>
+ <type>pom</type>
</dependency>
Review Comment:
The `org.graalvm.js:js` dependency is now declared with `<type>pom</type>`,
which makes Maven resolve the POM artifact instead of the JAR. That can remove
the `js` classes from the compile/runtime classpath, and it also conflicts with
distro assembly descriptors that still explicitly include
`org.graalvm.js:js:jar:${graalvm.version}` (e.g.,
`distro/src/main/assembly/hbase-agent.xml:78`). If the intent is to consume the
`js` JAR, drop the explicit type. If the intent is to import a BOM/POM, this
should typically be done under `<dependencyManagement>` with
`<scope>import</scope>`, and the assembly includes may need adjusting
accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
