ramackri commented on code in PR #1052:
URL: https://github.com/apache/ranger/pull/1052#discussion_r3551014255
##########
pom.xml:
##########
@@ -101,7 +101,7 @@
<google.guava.version>33.4.8-jre</google.guava.version>
<google.re2j.version>1.2</google.re2j.version>
<googlecode.log4jdbc.version>1.2</googlecode.log4jdbc.version>
- <graalvm.version>23.0.11</graalvm.version>
+ <graalvm.version>25.1.3</graalvm.version>
Review Comment:
**Follow-up: distro assembly descriptors need updating for GraalVM 25.1.3.**
The current includes reference artifacts that are no longer in the 25.1.3
dependency tree:
- `org.graalvm.js:js:jar` — no JAR exists at 25.1.3 (packaging is `pom`)
- `org.graalvm.sdk:graal-sdk:jar` — replaced by `polyglot` and finer-grained
SDK modules
- `com.ibm.icu:icu4j` — GraalVM 25 uses `org.graalvm.shadowed:icu4j` instead
With the current whitelist, agent tarballs may only bundle
`js-scriptengine`, `regex`, and `truffle-api`, while missing critical runtime
JARs such as `js-language`, `polyglot`, and `truffle-runtime`. Unit tests can
still pass because Maven puts the full transitive classpath on the test
classpath, but assembled agent plugins may fail at runtime when evaluating
JavaScript policies.
**Suggested replacement** (same change in `hive-agent.xml`,
`hbase-agent.xml`, `hdfs-agent.xml`, `plugin-solr.xml`, `plugin-yarn.xml`):
Replace:
```xml
<include>org.graalvm.js:js:jar:${graalvm.version}</include>
<include>org.graalvm.js:js-scriptengine:jar:${graalvm.version}</include>
<include>org.graalvm.regex:regex:jar:${graalvm.version}</include>
<include>org.graalvm.sdk:graal-sdk:jar:${graalvm.version}</include>
<include>org.graalvm.truffle:truffle-api:jar:${graalvm.version}</include>
<include>com.ibm.icu:icu4j</include>
```
With:
```xml
<!-- GraalJS 25.x runtime (js is now a POM, not a JAR) -->
<include>org.graalvm.js:js-language:jar:${graalvm.version}</include>
<include>org.graalvm.js:js-scriptengine:jar:${graalvm.version}</include>
<include>org.graalvm.polyglot:polyglot:jar:${graalvm.version}</include>
<include>org.graalvm.regex:regex:jar:${graalvm.version}</include>
<include>org.graalvm.truffle:truffle-api:jar:${graalvm.version}</include>
<include>org.graalvm.truffle:truffle-runtime:jar:${graalvm.version}</include>
<include>org.graalvm.truffle:truffle-compiler:jar:${graalvm.version}</include>
<include>org.graalvm.sdk:jniutils:jar:${graalvm.version}</include>
<include>org.graalvm.sdk:collections:jar:${graalvm.version}</include>
<include>org.graalvm.sdk:nativeimage:jar:${graalvm.version}</include>
<include>org.graalvm.sdk:word:jar:${graalvm.version}</include>
<include>org.graalvm.shadowed:icu4j:jar:${graalvm.version}</include>
<include>org.graalvm.shadowed:xz:jar:${graalvm.version}</include>
```
This matches the `agents-common` dependency tree at 25.1.3:
```
js:pom
├── js-language → regex, truffle-api, jniutils, shadowed:icu4j → shadowed:xz
└── truffle-runtime → truffle-compiler
js-scriptengine → polyglot → collections, nativeimage → word
```
**Verification:** after updating, build a hive-agent tarball and confirm
`js-language-*.jar`, `polyglot-*.jar`, and `truffle-runtime-*.jar` are present
under `lib/ranger-hive-plugin-impl/`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
