pradeepagrawal8184 commented on PR #1103:
URL: https://github.com/apache/ranger/pull/1103#issuecomment-5291483900
| # | Severity | Location | Issue |
|---|----------|----------|-------|
| 1 | **Critical** | `ranger-usersync-services.sh:100` | Log dir check uses
literal `RANGER_USERSYNC_LOG_DIR` instead of `"${RANGER_USERSYNC_LOG_DIR}"`.
Directory may never be created. |
| 2 | **High** | `spring-security.xml:26-36` | `/api/metrics/**` has no
`security="none"` or `permitAll`. Admin uses `<security:http
pattern="/service/metrics/**" security="none" />`. Metrics scraping may fail or
redirect to `/login`. |
| 3 | **High** | `MetricCacheUtil.java` | `HashMap` counters are written
from the sync thread and read from Tomcat/REST threads with no synchronization.
Risk of lost updates or corruption. |
| 4 | **High** | `PolicyMgrUserGroupBuilder.getUserGroupAuditInfo()` |
`AUDIT_COUNT_SUCCESS` is incremented unconditionally after failures; null
responses can also NPE in `JsonUtils.jsonToObject()`. |
| 5 | **High** | `UserSyncMetricsWrapper.java` | Missing
`RangerMetricsContainerSource` (KMS adds it explicitly). Tomcat
connection/thread metrics won’t appear in Prometheus/JSON output. |
| 6 | **High** | `ranger_usersync.py` | Still launches
`UnixAuthenticationService` with `lib/*` classpath. Ambari/Monarch installs
won’t use the new webapp entry point. |
| 7 | **High** | `ranger-usersync-services.sh` | `VERSION` still uses
`${cdir}/lib`; classpath still includes stale `${cdir}/lib/*` after assembly
moved jars to `ews/lib`. |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
