Sanket-Shelar commented on code in PR #1103: URL: https://github.com/apache/ranger/pull/1103#discussion_r3821595212
########## ugsync/src/main/java/org/apache/ranger/metrics/MetricCacheUtil.java: ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.ranger.metrics; + +import java.util.Map; +import java.util.Objects; +import java.util.concurrent.ConcurrentHashMap; + +public class MetricCacheUtil { + public static final String ADD_USER_COUNT_SUCCESS = "AddUserCountSUCCESS"; + public static final String ADD_USER_COUNT_FAIL = "AddUserCountFAIL"; + public static final String GROUP_USER_COUNT_SUCCESS = "GroupUserCountSUCCESS"; + public static final String GROUP_USER_COUNT_FAIL = "GroupUserCountFAIL"; + public static final String ADD_GROUP_COUNT_SUCCESS = "AddGroupCountSUCCESS"; + public static final String ADD_GROUP_COUNT_FAIL = "AddGroupCountFAIL"; + public static final String DELETE_USER_COUNT_SUCCESS = "DeleteUserCountSUCCESS"; + public static final String DELETE_USER_COUNT_FAIL = "DeleteUserCountFAIL"; + public static final String DELETE_GROUP_COUNT_SUCCESS = "DeleteGroupCountSUCCESS"; + public static final String DELETE_GROUP_COUNT_FAIL = "DeleteGroupCountFAIL"; + public static final String AUDIT_COUNT_SUCCESS = "AuditCountSUCCESS"; + public static final String AUDIT_COUNT_FAIL = "AuditCountFAIL"; + public static final String NO_OF_CACHED_USERS = "CountUSER"; + public static final String NO_OF_CACHED_GROUPS = "CountGROUP"; + public static final String NO_OF_CACHED_GROUPS_USERS = "CountGROUPUSER"; + private static MetricCacheUtil metricCacheUtil; + private Map<String, Long> apiMetrics = new ConcurrentHashMap<>(); + private Map<String, Long> cacheMetrics = new ConcurrentHashMap<>(); + private Map<String, Long> sourceMetrics = new ConcurrentHashMap<>(); + + private MetricCacheUtil() { + } + + public static MetricCacheUtil getInstance() { + if (Objects.isNull(metricCacheUtil)) { + synchronized (MetricCacheUtil.class) { + if (Objects.isNull(metricCacheUtil)) { + metricCacheUtil = new MetricCacheUtil(); + } + } + } + return metricCacheUtil; + } + + public void incrementMetric(MetricType metricType, String metricName, Long newValue) { + Map<String, Long> metric = getMetric(metricType); + + if (Objects.nonNull(metric)) { + if (metricType.equals(MetricType.CACHE) || metricType.equals(MetricType.SYNCSOURCE)) { + metric.put(metricName, newValue); + } else { + metric.merge(metricName, newValue, Long::sum); + } + } + } + + public Map<String, Long> getMetric(MetricType metricType) { Review Comment: Updated getMetric() to return an unmodifiable defensive copy. Introduced a private getInternalMetric() so incrementMetric() continues to update the live maps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
