vyommani commented on code in PR #1152:
URL: https://github.com/apache/ranger/pull/1152#discussion_r3796971103
##########
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java:
##########
@@ -233,6 +233,7 @@ public class ServiceDBStore extends AbstractServiceStore {
public static final String
RANGER_PLUGINS_CONFIG_CONF_PREFIX = "ranger.plugins.conf.";
public static final String HIDDEN_PASSWORD_STR
= "*****";
public static final String CONFIG_KEY_PASSWORD
= "password";
+ public static final String CONFIG_TYPE_PASSWORD
= "password";
Review Comment:
They both currently equal "password", but they're matched against completely
different fields — the shared value is coincidental, not a duplicate:
1-> CONFIG_KEY_PASSWORD — the literal config key name. Compared against
configKey (e.g. svcConfMap.getConfigkey()), to catch the legacy case where a
config item is literally named "password", regardless of what the service-def
says about it.
2-> CONFIG_TYPE_PASSWORD — the service-def declared config type.
Compared against svcConfDef.getType(), to catch config items with any key name
(e.g. nifi.ssl.keystorePassword) that the service-def marks as type="password".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
