vyommani commented on code in PR #1156:
URL: https://github.com/apache/ranger/pull/1156#discussion_r3797726501
##########
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java:
##########
@@ -679,7 +679,7 @@ private int getMaxDepth() {
}
private Character getLookupChar(char ch) {
- return optIgnoreCase ? Character.toLowerCase(ch) : ch;
+ return optIgnoreCase ?
Character.toLowerCase(Character.toUpperCase(ch)) : ch;
Review Comment:
Your latest tests look good, but they're a bit complex and don't exercise
the public API (RangerBasePlugin.isAccessAllowed). I spent some time and wrote
a test that fails without the fix and passes with it — please take a look at
the attached test, and feel free to include it in the PR if you find it
valuable.
[TrieCaseFoldDenySkipTest.java](https://github.com/user-attachments/files/31150021/TrieCaseFoldDenySkipTest.java)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
