mneethiraj commented on code in PR #1174:
URL: https://github.com/apache/ranger/pull/1174#discussion_r3885899732
##########
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java:
##########
@@ -1177,6 +1177,14 @@ public Collection<String> getRolesByLoginId(String
loginId) {
return roleList;
}
+ public boolean isUserDisabled(String loginId) {
Review Comment:
`isUserDisabled()` method checks if the user status is "not active", which
is different from disabled status. I suggest naming the method to
`isUserActive()` and update all its references to handle the return value.
##########
security-admin/src/main/java/org/apache/ranger/security/handler/RangerAuthenticationProvider.java:
##########
@@ -701,6 +714,13 @@ private Authentication
getJDBCAuthentication(Authentication authentication, Stri
return authentication;
}
+ private void checkAccountNotDisabled(String userName) {
Review Comment:
I suggest renaming method `checkAccountNotDisabled()` to
`ensureUserIsActive()`. Also, update the messages to replace "disabled" with
"not active".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
