mneethiraj commented on code in PR #1174:
URL: https://github.com/apache/ranger/pull/1174#discussion_r3887294633
##########
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java:
##########
@@ -1177,6 +1177,14 @@ public Collection<String> getRolesByLoginId(String
loginId) {
return roleList;
}
+ public boolean isUserDisabled(String loginId) {
Review Comment:
The method implementation checks if user is not active i.e., not explicitly
if the user is disabled - note an user can be in one of other statuses like
deactivated. So, I suggest:
- renaming `isUserDisabled()` to `isUserNotActive()`
- renaming `checkAccountNotDisabled() to `blockNotActiveUser()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
