eoinmcdonnell113 commented on code in PR #1232:
URL: https://github.com/apache/ranger/pull/1232#discussion_r4212091359


##########
security-admin/src/test/java/org/apache/ranger/biz/TestServiceMgr.java:
##########
@@ -385,4 +385,79 @@ public void 
test13_validateConfig_allowsLegitimateExternalUrls() throws Exceptio
         Assertions.assertNotNull(response);
         Assertions.assertNotEquals(VXResponse.STATUS_ERROR, 
response.getStatusCode());
     }
+
+    @Test
+    public void test14_validateConfig_sanitizesConnectionRefusedDetails() 
throws Exception {

Review Comment:
   Done — extracted shared setup into prepareValidateConfigTest() / 
stubValidateConfigResponse() so test14 and test15 only keep the differing 
response values and assertions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to