eoinmcdonnell113 commented on code in PR #1232:
URL: https://github.com/apache/ranger/pull/1232#discussion_r4212097147
##########
security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java:
##########
@@ -726,6 +730,13 @@ private VXResponse generateResponseForTestConn(Map<String,
Object> responseData,
}
}
+ if (!connectivityStatus && disclosesHostPortReachability(message,
description)) {
+ LOG.error("Test Connection failed; sanitizing UI response.
Original message=[{}] description=[{}]", message, description);
Review Comment:
Good catch. Both UI fields still need to be sanitized (message and
description can both reach the UI), but the log was noisy when they were
identical. Updated to log a single Original=[...] when message and description
match, and keep both only when they differ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
