vyommani commented on code in PR #1327:
URL: https://github.com/apache/ranger/pull/1327#discussion_r4356961324
##########
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java:
##########
@@ -50,7 +52,8 @@
public class RangerServiceDefValidator extends RangerValidator {
private static final Logger LOG =
LoggerFactory.getLogger(RangerServiceDefValidator.class);
- private static final Set<String> VALID_CONFIG_TYPES =
ImmutableSet.of("bool", "enum", "int", "string", "password", "path");
+ private static final Set<String> VALID_CONFIG_TYPES =
ImmutableSet.of("bool", "enum", "int", "string", "password", "path");
+ private static final Set<String> VALID_CONSTRAINT_PARAM_TYPES =
ImmutableSet.of("string", "int", "bool", "enum", "user", "group", "role");
Review Comment:
user, group, and role are for an approver-style parameter. The value stored
on the policy is still a string, a user, group, or role name. The type tells
the UI which picker to show. They are not service-config types: password and
path stay rejected, and isValidConfigType rejects user, group, and role.
requireApproval uses an approver of type user or group. I can drop them if a
plain string is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
