vyommani commented on code in PR #1327:
URL: https://github.com/apache/ranger/pull/1327#discussion_r4365972882
##########
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java:
##########
@@ -50,7 +52,8 @@
public class RangerServiceDefValidator extends RangerValidator {
private static final Logger LOG =
LoggerFactory.getLogger(RangerServiceDefValidator.class);
- private static final Set<String> VALID_CONFIG_TYPES =
ImmutableSet.of("bool", "enum", "int", "string", "password", "path");
+ private static final Set<String> VALID_CONFIG_TYPES =
ImmutableSet.of("bool", "enum", "int", "string", "password", "path");
+ private static final Set<String> VALID_CONSTRAINT_PARAM_TYPES =
ImmutableSet.of("string", "int", "bool", "enum", "user", "group", "role");
Review Comment:
It is not a requirement for this change. The value is stored as a string,
and neither the UI nor Admin checks that it is an existing user, group, or
role. I removed user, group, and role. The parameter types are string, int,
bool, and enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
