----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31763/#review75607 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java <https://reviews.apache.org/r/31763/#comment122806> surround with if(LOG.isDebugEnabled()) { } security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java <https://reviews.apache.org/r/31763/#comment122812> For CREATE, id field can be empty. Please update to handle this case. security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java <https://reviews.apache.org/r/31763/#comment122813> For CREATE, id in the incoming policy should be ignored - as the store will assign a new ID to the created policy. security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java <https://reviews.apache.org/r/31763/#comment122809> Look for policies within this service only. It is a valid case for other services to contain a policy with this name. security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java <https://reviews.apache.org/r/31763/#comment122808> if the policy was renamed, then there shouldn't be any policy with the new name. Please review this condition. security-admin/src/main/java/org/apache/ranger/rest/RangerServiceValidator.java <https://reviews.apache.org/r/31763/#comment122815> id field can be null for CREATE action. Please update to handle this case. security-admin/src/main/java/org/apache/ranger/rest/RangerServiceValidator.java <https://reviews.apache.org/r/31763/#comment122814> For CREATE, id in the incoming service should be ignored - as the store will assign a new ID to the created policy. - Madhan Neethiraj On March 7, 2015, 1:32 a.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31763/ > ----------------------------------------------------------- > > (Updated March 7, 2015, 1:32 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-278 > https://issues.apache.org/jira/browse/RANGER-278 > > > Repository: ranger > > > Description > ------- > > Added validation for policy create/update/delete operations. Moved action out > of ctor to validate call. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/rest/RangerServiceValidator.java > 08184c7 > security-admin/src/main/java/org/apache/ranger/rest/RangerValidator.java > 3f25266 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > fc2178f > > security-admin/src/test/java/org/apache/ranger/rest/TestRangerPolicyValidator.java > PRE-CREATION > > security-admin/src/test/java/org/apache/ranger/rest/TestRangerServiceValidator.java > 3bbb123 > > security-admin/src/test/java/org/apache/ranger/rest/TestRangerValidator.java > PRE-CREATION > > security-admin/src/test/java/org/apache/ranger/rest/TestServiceRESTForValidation.java > 483e914 > > security-admin/src/test/java/org/apache/ranger/rest/TestServiceValidator.java > a1879c4 > > security-admin/src/test/java/org/apache/ranger/rest/ValidationTestUtils.java > 0925aa1 > > Diff: https://reviews.apache.org/r/31763/diff/ > > > Testing > ------- > > Additional junits added. Patch allies to latest trunk. > > > Thanks, > > Alok Lal > >
