> On March 6, 2015, 6:40 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java, > > line 42 > > <https://reviews.apache.org/r/31763/diff/2/?file=888159#file888159line42> > > > > surround with if(LOG.isDebugEnabled()) { > > }
Done. > On March 6, 2015, 6:40 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java, > > line 108 > > <https://reviews.apache.org/r/31763/diff/2/?file=888159#file888159line108> > > > > For CREATE, id field can be empty. Please update to handle this case. Done. > On March 6, 2015, 6:40 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java, > > line 118 > > <https://reviews.apache.org/r/31763/diff/2/?file=888159#file888159line118> > > > > For CREATE, id in the incoming policy should be ignored - as the store > > will assign a new ID to the created policy. Done. > On March 6, 2015, 6:40 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java, > > line 146 > > <https://reviews.apache.org/r/31763/diff/2/?file=888159#file888159line146> > > > > Look for policies within this service only. It is a valid case for > > other services to contain a policy with this name. Done. > On March 6, 2015, 6:40 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java, > > line 149 > > <https://reviews.apache.org/r/31763/diff/2/?file=888159#file888159line149> > > > > if the policy was renamed, then there shouldn't be any policy with the > > new name. Please review this condition. Done. > On March 6, 2015, 6:40 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/rest/RangerServiceValidator.java, > > line 128 > > <https://reviews.apache.org/r/31763/diff/2/?file=888160#file888160line128> > > > > id field can be null for CREATE action. Please update to handle this > > case. done. > On March 6, 2015, 6:40 p.m., Madhan Neethiraj wrote: > > security-admin/src/main/java/org/apache/ranger/rest/RangerServiceValidator.java, > > line 137 > > <https://reviews.apache.org/r/31763/diff/2/?file=888160#file888160line137> > > > > For CREATE, id in the incoming service should be ignored - as the store > > will assign a new ID to the created policy. Done. - Alok ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31763/#review75607 ----------------------------------------------------------- On March 9, 2015, 1:43 p.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31763/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 1:43 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-278 > https://issues.apache.org/jira/browse/RANGER-278 > > > Repository: ranger > > > Description > ------- > > Added validation for policy create/update/delete operations. Moved action out > of ctor to validate call. > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java > ab8384c > > security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/rest/RangerServiceValidator.java > 08184c7 > security-admin/src/main/java/org/apache/ranger/rest/RangerValidator.java > 3f25266 > > security-admin/src/test/java/org/apache/ranger/rest/TestRangerPolicyValidator.java > PRE-CREATION > > security-admin/src/test/java/org/apache/ranger/rest/TestRangerServiceValidator.java > 3bbb123 > > Diff: https://reviews.apache.org/r/31763/diff/ > > > Testing > ------- > > Additional junits added. Patch allies to latest trunk. > > > Thanks, > > Alok Lal > >
