----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31854/#review75799 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java <https://reviews.apache.org/r/31854/#comment123092> To aid in troubleshooting, tt will be helpful to include the policy-id in the message. security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java <https://reviews.apache.org/r/31854/#comment123093> To aid in troubleshooting, tt will be helpful to include the policy-id in the message. security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java <https://reviews.apache.org/r/31854/#comment123094> For better readability, line# 256 can be moved inside the following if(), after line# 258. security-admin/src/main/java/org/apache/ranger/rest/RangerServiceValidator.java <https://reviews.apache.org/r/31854/#comment123096> To aid in troubleshooting, tt will be helpful to include the service-id in the message. security-admin/src/main/java/org/apache/ranger/rest/RangerServiceValidator.java <https://reviews.apache.org/r/31854/#comment123097> To aid in troubleshooting, tt will be helpful to include the service-type name in the message. security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java <https://reviews.apache.org/r/31854/#comment123098> Validation missing for policy CREATE. - Madhan Neethiraj On March 9, 2015, 6:56 a.m., Alok Lal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31854/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 6:56 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-278 > https://issues.apache.org/jira/browse/RANGER-278 > > > Repository: ranger > > > Description > ------- > > - policy validation > - rework comments from https://reviews.apache.org/r/31763/ addressed (Unable > to apply patch to that review) > - id is ignored for create of service and policy, allow for updating of > policy/service name > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java > ab8384c > > security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/rest/RangerServiceValidator.java > 08184c7 > security-admin/src/main/java/org/apache/ranger/rest/RangerValidator.java > 3f25266 > > security-admin/src/main/java/org/apache/ranger/rest/RangerValidatorFactory.java > 6c75a2f > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > fc2178f > > security-admin/src/test/java/org/apache/ranger/rest/TestRangerPolicyValidator.java > PRE-CREATION > > security-admin/src/test/java/org/apache/ranger/rest/TestRangerServiceValidator.java > 3bbb123 > > security-admin/src/test/java/org/apache/ranger/rest/TestRangerValidator.java > PRE-CREATION > > security-admin/src/test/java/org/apache/ranger/rest/TestServiceRESTForValidation.java > 483e914 > > security-admin/src/test/java/org/apache/ranger/rest/TestServiceValidator.java > a1879c4 > > security-admin/src/test/java/org/apache/ranger/rest/ValidationTestUtils.java > 0925aa1 > > Diff: https://reviews.apache.org/r/31854/diff/ > > > Testing > ------- > > Madhan, > I was not able to apply this patch to prior review hence, I had to create a > new review. :( > JUnits were updated to account for review comments about optional id and > update of name. > > > Thanks, > > Alok Lal > >
